Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move setuptools._path.StrPath out of the if TYPE_CHECKING (Python 3.9+) #4722

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Move setuptools._path.StrPath out of the if TYPE_CHECKING (Python 3.9+) #4722

merged 1 commit into from
Oct 31, 2024

Conversation

abravalheri
Copy link
Contributor

Summary of changes

Implement @Avasam suggestions from #4718 (comment):

You can move setuptools._path.StrPat out of the TYPE_CHECKING check

Closes

Pull Request Checklist

@abravalheri abravalheri mentioned this pull request Oct 31, 2024
Merged
2 tasks
@abravalheri abravalheri merged commit c032a5b into pypa:main Oct 31, 2024
24 checks passed
@abravalheri abravalheri deleted the more-3.9-updates-2 branch October 31, 2024 13:44
@stanislavlevin stanislavlevin mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avasam Avasam Avasam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abravalheri @Avasam